-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TaskProcessing] Add support for webhooks #46579
Conversation
bf823db
to
13b1762
Compare
d32cbc3
to
eae5fcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm not sure I understand the purpose of these changes. Is this part of the new webhook stuff or specific to task processing api? If it is the former then it seems wrong to me to implement it in the task processing api? Maybe I'm missing something though. |
e107dfc
to
5fac324
Compare
It seems like the 3rd party repo is not up to date in master. The I don't really get why the OpenAPI action is failing though. |
The OpenAPI failure is random, it seems to happen once in a while without an apparent reason. |
@provokateurin If we think about the workflow engine, it would indeed be possible in a flow to:
But it is way more simple to:
Having the webhook_listeners app does not prevent us from implementing webhook-like features in other places where it's convenient. That's the reasoning behind this PR. |
5fac324
to
bb393a7
Compare
…e task processing API Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
bb393a7
to
78c09b5
Compare
Questions: