Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(caldav): Throw 403 Forbidden Error instead of 500 Internal Server… #46593

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix(caldav): Throw 403 Forbidden Error instead of 500 Internal Server… #46593

merged 1 commit into from
Jul 18, 2024

Conversation

SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski self-assigned this Jul 17, 2024
ChristophWurst
ChristophWurst approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

apps/dav/lib/CalDAV/CalDavBackend.php Show resolved Hide resolved
@SebastianKrupinski SebastianKrupinski added the 3. to review Waiting for reviews label Jul 17, 2024
@SebastianKrupinski
fix(caldav): Throw 403 Forbidden Error instead of 500 Internal Server…
0f3d05a 
… Error

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@ChristophWurst ChristophWurst merged commit 1de5adf into master Jul 18, 2024
166 checks passed
@ChristophWurst ChristophWurst deleted the fix/issue-30514 branch July 18, 2024 08:16
@ChristophWurst
Copy link
Member

/backport to stable29

@ChristophWurst
Copy link
Member

/backport to stable28

@backportbot backportbot bot mentioned this pull request Jul 18, 2024
Merged
@backportbot backportbot bot mentioned this pull request Jul 18, 2024
Merged
@SebastianKrupinski SebastianKrupinski added this to the Nextcloud 30 milestone Jul 23, 2024
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@miaulalala miaulalala miaulalala approved these changes

@st3iny st3iny Awaiting requested review from st3iny st3iny is a code owner

@kesselb kesselb Awaiting requested review from kesselb

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees

@SebastianKrupinski SebastianKrupinski

Labels
3. to review Waiting for reviews
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

[CalDAV] Nextcloud returns HTTP 500 instead of 403 when POSTing an event without valid instances
3 participants
@SebastianKrupinski @ChristophWurst @miaulalala