Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(caldav): decode values before returning #46594

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix(caldav): decode values before returning #46594

merged 1 commit into from
Jul 18, 2024

Conversation

SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski
fix(caldav): decode values before returning
79c97e7 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski self-assigned this Jul 17, 2024
@SebastianKrupinski SebastianKrupinski added the 3. to review Waiting for reviews label Jul 17, 2024
st3iny
st3iny approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. I reproduced the initial issue before applying the PR and it is fixed now.

@st3iny st3iny requested a review from miaulalala July 18, 2024 11:26
@st3iny
Copy link
Member

st3iny commented Jul 18, 2024

For reference, this is how the array looks before and after decoding:

Before After
Screenshot_20240718_132742 Screenshot_20240718_132752

@miaulalala
Copy link
Contributor

/backport to stable29

@miaulalala
Copy link
Contributor

/backport to stable28

@miaulalala miaulalala merged commit 5c20c9e into master Jul 18, 2024
166 checks passed
@miaulalala miaulalala deleted the fix/issue-28162-2 branch July 18, 2024 14:00
This was referenced Jul 18, 2024
Merged
Merged
@SebastianKrupinski SebastianKrupinski added this to the Nextcloud 30 milestone Jul 23, 2024
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@st3iny st3iny st3iny approved these changes

@kesselb kesselb Awaiting requested review from kesselb

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees

@SebastianKrupinski SebastianKrupinski

Labels
3. to review Waiting for reviews
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

Calendar: Invitations aren't sent if Nextcloud user has "+" sign in email address
3 participants
@SebastianKrupinski @st3iny @miaulalala