-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(comments): center align submit button in new comment field #46595
Conversation
Signed-off-by: Edward Ly <contact@edward.ly>
4cd8b43
to
61e6e22
Compare
I figured out how to do exactly that, with the added benefit being that the button remains centered regardless of the number of lines in the text box. Although, I'm not sure if that is preferable to before where the button is always on the last line, and the text may overlap with the button regardless.
|
Thanks for the PR, edward! I think, personally, I'd prefer 983f121, even if that is more of a dirty fix :D |
Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
45859dc
to
5a64828
Compare
Sorry for the wait, I reverted back to the quick and dirty fix now and cleaned up the branch commits. |
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
A quick and dirty fix for centering the submit button when the comments are first shown. If I have extra time, I could investigate alternative solutions that don't require hardcoded values.
Checklist