fix(comments): Extend Vue before calling new on it
#46643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kesselb
approved these changes
Jul 19, 2024
Pytal
approved these changes
Jul 19, 2024
susnux
force-pushed
the
fix/comments-vue-constructor
branch
from
77ce099
to
85ef5ae
Compare
|
/compile |
susnux
force-pushed
the
fix/comments-vue-constructor
branch
from
b3ac628
to
ea05554
Compare
|
/compile |
artonge
reviewed
Jul 22, 2024
artonge
force-pushed
the
fix/comments-vue-constructor
branch
2 times, most recently
from
894ef7b
to
8330eda
Compare
artonge
approved these changes
Jul 24, 2024
artonge
force-pushed
the
fix/comments-vue-constructor
branch
from
8330eda
to
ab5ac1f
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: Louis Chemineau <louis@chmn.me>
susnux
force-pushed
the
fix/comments-vue-constructor
branch
from
ab5ac1f
to
ece4aec
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#45848 introduced a regression as the Vue was not extended but the Vue component was directly tried to instantiate which does not work as a Vue component is basically an Object that does not has any constructor.
Checklist