Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Disable tags editing for shared files/folders with view only permission #46663

Closed
wants to merge 1 commit into from

Conversation

Koc
Copy link
Contributor

@Koc Koc commented Jul 21, 2024

How to reproduce

  1. Create file/folder and assign some tags to it
  2. Share it with another user "user" with view only permission
  3. Open it by "user"

Expected result: user not able remove/add tags
Actual result: user able remove/add tags on UI (we have http 403 on the server side, but UI allows this actions)

🔍 Folder details for admin

image

🔍 Folder details for user

image

Checklist

@Koc Koc requested a review from skjnldsv as a code owner July 21, 2024 13:48
@solracsf solracsf requested review from susnux and Pytal July 21, 2024 14:37
@solracsf solracsf added the 3. to review Waiting for reviews label Jul 21, 2024
@solracsf solracsf added this to the Nextcloud 30 milestone Jul 21, 2024
apps/systemtags/src/components/SystemTags.vue Outdated Show resolved Hide resolved
apps/files/src/services/FileInfo.js Outdated Show resolved Hide resolved
@Koc Koc force-pushed the fix/disable-tags-editing branch from 4a79261 to e738c9c Compare July 22, 2024 22:21
@susnux susnux added the bug label Jul 25, 2024
This was referenced Jul 30, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@Altahrim Altahrim mentioned this pull request Aug 7, 2024
…nly permission

Signed-off-by: Konstantin Myakshin <molodchick@gmail.com>
@AndyScherzinger
Copy link
Member

/compile /

@AndyScherzinger
Copy link
Member

successor to move in into this repo away from the fork: #47149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants