Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Reduce preview size in grid view mode #46681

Merged
merged 3 commits into from
Jul 24, 2024
Merged

fix(files): Reduce preview size in grid view mode #46681

merged 3 commits into from
Jul 24, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jul 22, 2024 •
edited
Loading

@artonge artonge requested a review from skjnldsv as a code owner July 22, 2024 13:06
@artonge artonge force-pushed the artonge/fix/grid_view_preview_size branch from be2ebfe to 27c0bef Compare July 22, 2024 13:09
jancborchardt
jancborchardt approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me! @jospoortvliet @karlitschek FYI

@karlitschek
Copy link
Member

looks good. thanks

@artonge artonge requested review from susnux, Fenn-CS and Pytal July 23, 2024 12:11
@artonge artonge self-assigned this Jul 23, 2024
@artonge artonge added this to the Nextcloud 30 milestone Jul 23, 2024
@artonge artonge requested a review from yemkareems July 23, 2024 12:19
@artonge
fix(files): Reduce preview size in grid view mode
ddad7b4 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
fix(files): Grid view virtual scrolling computations
1aeb3f3 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/grid_view_preview_size branch from 0d6190e to 3c69065 Compare July 24, 2024 07:42
@artonge artonge enabled auto-merge July 24, 2024 07:42
@artonge
chore: Compile assets
d32ea63 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/grid_view_preview_size branch from 3c69065 to d32ea63 Compare July 24, 2024 07:53
@artonge artonge merged commit f3a2806 into master Jul 24, 2024
109 checks passed
@artonge artonge deleted the artonge/fix/grid_view_preview_size branch July 24, 2024 08:25
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@yemkareems yemkareems yemkareems approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

@jospoortvliet jospoortvliet Awaiting requested review from jospoortvliet

@karlitschek karlitschek Awaiting requested review from karlitschek

@susnux susnux Awaiting requested review from susnux

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews enhancement feature: files javascript
Projects
🖍 Design team
Archived in project
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@artonge @karlitschek @jancborchardt @yemkareems