fix: keep previous exception when wrapping dav exceptions #46685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
yemkareems and
sorbaugh
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } catch (InvalidPathException $ex) { | ||
| throw new InvalidPath($ex->getMessage()); | ||
| throw new InvalidPath($ex->getMessage(), $ex->getCode(), $ex); |
Check failure
Code scanning / Psalm
InvalidArgument Error
| } catch (ForbiddenException $e) { | ||
| throw new \Sabre\DAV\Exception\Forbidden(); | ||
| throw new \Sabre\DAV\Exception\Forbidden($ex->getMessage(), $ex->getRetry(), $ex); |
Check failure
Code scanning / Psalm
UndefinedVariable Error
| } catch (ForbiddenException $e) { | ||
| throw new \Sabre\DAV\Exception\Forbidden(); | ||
| throw new \Sabre\DAV\Exception\Forbidden($ex->getMessage(), $ex->getRetry(), $ex); |
Check failure
Code scanning / Psalm
UndefinedVariable Error
| } catch (ForbiddenException $e) { | ||
| throw new \Sabre\DAV\Exception\Forbidden(); | ||
| throw new \Sabre\DAV\Exception\Forbidden($ex->getMessage(), $ex->getRetry(), $ex); |
Check failure
Code scanning / Psalm
UndefinedVariable Error
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
sabre-directory-exception-previous
branch
from
d16ad2a
to
d5a2a4a
Compare
yemkareems
approved these changes
Jul 25, 2024
sorbaugh
approved these changes
Jul 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to throw away valuable context