Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @nextcloud/files to 3.6.0 and fix display name handling of folders (breadcrumbs and filename) #46690

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Update @nextcloud/files to 3.6.0 and fix display name handling of folders (breadcrumbs and filename) #46690

merged 4 commits into from
Jul 25, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 22, 2024 •
edited
Loading

Summary

  1. Update to current version 3.6.0 of nextcloud-files (drop duplicated code)
  2. For folders do not cut-off the extension as folders do not have extensions they are part of the filename, this fixes names of folder in the file list and in the bread crumbs

Checklist

@susnux susnux added this to the Nextcloud 30 milestone Jul 22, 2024
@susnux susnux requested review from artonge, Fenn-CS and Pytal July 22, 2024 16:14
@susnux susnux requested a review from skjnldsv as a code owner July 22, 2024 16:14
@susnux
Copy link
Contributor Author

susnux commented Jul 22, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Jul 22, 2024

/backport to stable28

@susnux susnux requested a review from sorbaugh July 22, 2024 16:19
@susnux susnux changed the title Update @nextcloud/files to 3.6.0 and fix display name handling of folders (bread crumbs and filename) Update @nextcloud/files to 3.6.0 and fix display name handling of folders (breadcrumbs and filename) Jul 22, 2024
@susnux susnux mentioned this pull request Jul 22, 2024
Closed
@susnux
Copy link
Contributor Author

susnux commented Jul 24, 2024

/compile

@susnux susnux mentioned this pull request Jul 24, 2024
Closed
susnux and others added 4 commits July 25, 2024 01:24
@susnux
chore(deps): Update @nextcloud/files to v3.6.0
f95d826 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(files): Do not split filename into base and extension for fol…
5dc8e06 
…ders

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix: Ensure displayname is a string
80d797e 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@nextcloud-command @susnux
chore(assets): Recompile assets
fe1aa83 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit d843d67 into master Jul 25, 2024
109 checks passed
@susnux susnux deleted the fix/files-displayname branch July 25, 2024 00:09
This was referenced Jul 25, 2024
Merged
Merged
@susnux susnux mentioned this pull request Jul 25, 2024
Closed
4 tasks
@blizzz blizzz mentioned this pull request Jul 25, 2024
Merged
@joshtrichards joshtrichards mentioned this pull request Aug 30, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@Fenn-CS Fenn-CS Fenn-CS approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: files
Projects
None yet
Milestone
Nextcloud 30
4 participants
@susnux @artonge @Fenn-CS @nextcloud-command