feat: add a specialized writeStream implementation for s3 external storage #46693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
Altahrim and
yemkareems
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
icewind1991
force-pushed
the
s3-writestream-impl
branch
from
0bea0f2
to
a3b6396
Compare
icewind1991
force-pushed
the
s3-writestream-impl
branch
from
a3b6396
to
ed7fe9a
Compare
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
artonge
reviewed
Jul 23, 2024
…orage Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
s3-writestream-impl
branch
from
ed7fe9a
to
c2b1f07
Compare
artonge
approved these changes
Jul 25, 2024
sorbaugh
approved these changes
Jul 25, 2024
This was referenced Jul 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should both reduce overhead and improve detection of failed writes