Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(caldav): stricter default calendar checks #46696

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 23, 2024

Backport of #45667

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels Jul 23, 2024
@backportbot backportbot bot added this to the Nextcloud 29.0.5 milestone Jul 23, 2024
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added all missing changes.

Reject calendars that
- are subscriptions
- are not writable
- are shared with a user
- are deleted
- don't support VEVENTs

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny marked this pull request as ready for review July 23, 2024 06:50
@st3iny st3iny requested a review from tcitworld as a code owner July 23, 2024 06:50
@miaulalala miaulalala merged commit f9235a0 into stable29 Jul 23, 2024
179 of 181 checks passed
@miaulalala miaulalala deleted the backport/45667/stable29 branch July 23, 2024 08:11
@Altahrim Altahrim mentioned this pull request Aug 8, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug feature: caldav Related to CalDAV internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants