Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TaskProcessing): Implement enums and default values #46722

Merged
merged 11 commits into from
Jul 25, 2024

Conversation

marcelklehr
Copy link
Member

Summary

This adds Enum types to input and outputs of Tasks and allows providers to specify the values of those enums, as well as default values for any input slots.

Checklist

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 💥 👍 ❤️

@julien-nc julien-nc force-pushed the enh/noid/taskprocessing-enums-defaults branch from 93753c1 to bd75919 Compare July 24, 2024 13:43
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick, feature freeze is tomorrow :D

@julien-nc julien-nc force-pushed the enh/noid/taskprocessing-enums-defaults branch from 0f632ea to 8a29073 Compare July 24, 2024 14:48
lib/private/TaskProcessing/Manager.php Outdated Show resolved Hide resolved
marcelklehr and others added 7 commits July 25, 2024 10:10
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Co-authored-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@julien-nc julien-nc force-pushed the enh/noid/taskprocessing-enums-defaults branch from e54f8d0 to 6363437 Compare July 25, 2024 08:10
@julien-nc julien-nc self-requested a review July 25, 2024 08:10
marcelklehr and others added 4 commits July 25, 2024 10:23
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc enabled auto-merge July 25, 2024 08:51
),
'target_language' => new ShapeDescriptor(
$this->l->t('Target language'),
$this->l->t('The desired language to translate the origin text in'),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$this->l->t('The desired language to translate the origin text in'),
$this->l->t('The desired language to translate the origin text to'),

Copy link
Member Author

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve

@julien-nc julien-nc merged commit ea7eeb2 into master Jul 25, 2024
167 checks passed
@julien-nc julien-nc deleted the enh/noid/taskprocessing-enums-defaults branch July 25, 2024 09:03
@marcelklehr
Copy link
Member Author

Woop wooop

@blizzz blizzz mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants