Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): always ask for confirmation if trashbin app is disabled #46786

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

skjnldsv
Copy link
Member

Fix #46733

@skjnldsv
Copy link
Member Author

/backport to stable28

@skjnldsv
Copy link
Member Author

/backport to stable29

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really important thing, nice work!

@skjnldsv
Copy link
Member Author

/compile rebase-amend /dist

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 27, 2024
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv enabled auto-merge July 27, 2024 07:26
@skjnldsv skjnldsv merged commit 0ea0667 into master Jul 27, 2024
109 checks passed
@skjnldsv skjnldsv deleted the fix/trashbin-deletion branch July 27, 2024 07:28
@blizzz blizzz mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files feature: trashbin high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always ask before deletion if trashbin is disabled
3 participants