Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Don't try to use missing cache entries #46840

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skazi0
Copy link

@skazi0 skazi0 commented Jul 29, 2024

Summary

The Cache::get() function can return ICacheEntry or false. Added check ensures that false return value is not used as an array. This silences: Trying to access array offset on value of type bool errors.

@solracsf solracsf added this to the Nextcloud 30 milestone Jul 29, 2024
@solracsf solracsf added the 3. to review Waiting for reviews label Jul 29, 2024
@solracsf solracsf requested review from a team, ArtificialOwl, Altahrim and yemkareems and removed request for a team July 29, 2024 12:44
The `Cache::get()` function can return `ICacheEntry` or `false`.
Added check ensures that `false` return value is not used as an array.
This silences: `Trying to access array offset on value of type bool` errors.

Signed-off-by: Jacek Tomasiak <jacek.tomasiak@gmail.com>
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants