fix: don't persist previews used during blurhash generation - take 2 #46864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
added
bug
3. to review
st3iny
force-pushed
the
fix/dont-persist-blurhash-preview-2
branch
from
644f795
to
82bd502
Compare
|
/backport to stable29 |
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
fix/dont-persist-blurhash-preview-2
branch
from
82bd502
to
08c785f
Compare
st3iny
changed the title
Merged
kesselb
approved these changes
Jul 30, 2024
|
A good hardening would be a check is the given file bigger than x. |
Merged
come-nc
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When an instance is updated to 29 or 30, a blurhash is generated for every image in the background. For performance reasons, the blurhash generator requests a scaled preview instead of the full image. On large instances this is a problem because a preview will be generated and persisted for every image on the server.
Now, the preview is generated on the fly and not persisted to disk.
A cleaner alternative to #46864.
Checklist