-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: try to find non-recursive share source #46881
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of always picking the first one, try to find one that won't blow up Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
a team,
ArtificialOwl,
Altahrim and
yemkareems
and removed request for
a team
July 30, 2024 13:34
Merged
$this->cache = null; | ||
break; | ||
} | ||
if (!$this->nonMaskedStorage) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction Note
Operand of type false is always falsy
$this->cache = null; | ||
break; | ||
} | ||
if (!$this->nonMaskedStorage) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction Note
Docblock-defined type OCP\Files\Storage\IStorage for $this->nonMaskedStorage is never falsy
AndyScherzinger
approved these changes
Jul 31, 2024
Merged
come-nc
approved these changes
Aug 1, 2024
/backport to stable29 |
/backport to stable28 |
/backport to stable27 |
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of always picking the first one, try to find one that won't blow up.
To test: