Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files_sharing): Add missing "note to recipient" #46892

Merged
merged 4 commits into from
Jul 31, 2024
Merged

fix(files_sharing): Add missing "note to recipient" #46892

merged 4 commits into from
Jul 31, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 30, 2024 •
edited
Loading

Summary

Add back the "note to recipient" for internal / authenticated files view.
Also implement the design comments about making it more obvious (similar to rich workspaces).

Screenshots

before after
Screenshot 2024-07-30 at 19-26-36 Files - Nextcloud Screenshot 2024-07-30 at 19-33-27 Files - Nextcloud

Checklist

@susnux susnux added this to the Nextcloud 30 milestone Jul 30, 2024
@susnux susnux mentioned this pull request Jul 30, 2024
Merged
12 tasks
@susnux susnux force-pushed the fix/add-note-to-recipient branch from adf7164 to e0975d1 Compare July 30, 2024 19:59
skjnldsv
skjnldsv approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy! I like the approach 👍

@susnux susnux force-pushed the fix/add-note-to-recipient branch from e0975d1 to a5bcc96 Compare July 31, 2024 09:19
jancborchardt
jancborchardt approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good! :)

@jancborchardt jancborchardt mentioned this pull request Jul 31, 2024
Closed
3 tasks
@susnux
fix(files_sharing): Add missing "note to recipient"
d651819 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(files_sharing): Ensure "note to recipient" textarea is shown if t…
5b400c1 
…here is a note

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
test(files_sharing): Add test for "note to recipient" feature
5b8786d 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
1ce365a 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/add-note-to-recipient branch from a5bcc96 to 1ce365a Compare July 31, 2024 13:11
@susnux susnux merged commit 4ecd592 into master Jul 31, 2024
111 checks passed
@susnux susnux deleted the fix/add-note-to-recipient branch July 31, 2024 14:12
@blizzz blizzz mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: files feature: sharing
Projects
None yet
Milestone
Nextcloud 30
4 participants
@susnux @jancborchardt @AndyScherzinger @skjnldsv