Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve template filler bugs #46895

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Resolve template filler bugs #46895

merged 3 commits into from
Jul 31, 2024

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Jul 30, 2024

Summary

There were some bugs with the template filler which caused a bad user experience. The following bugs are resolved with this pull request:

  • Closing the template filler without submitting anything caused an issue where you could not return to the template picker
  • The template filler appeared even if the template did not have any fields

Checklist

Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@elzody elzody added this to the Nextcloud 30 milestone Jul 30, 2024
@elzody elzody requested a review from juliushaertl July 30, 2024 19:37
@elzody elzody self-assigned this Jul 30, 2024
@elzody elzody requested a review from skjnldsv as a code owner July 30, 2024 19:37
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@skjnldsv skjnldsv merged commit 45073f9 into master Jul 31, 2024
111 checks passed
@skjnldsv skjnldsv deleted the fix/template-filler branch July 31, 2024 06:25
@skjnldsv
Copy link
Member

image

@elzody committing assets is not a fix :)

@elzody
Copy link
Contributor Author

elzody commented Jul 31, 2024

@skjnldsv what would be more appropriate?

@blizzz blizzz mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template form filling bugs
3 participants