Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files_sharing): filter out invalid shareWith in sharee API #46924

Merged
merged 1 commit into from
Aug 6, 2024
Merged

fix(files_sharing): filter out invalid shareWith in sharee API #46924

merged 1 commit into from
Aug 6, 2024

Conversation

skjnldsv
Copy link
Member

Prevent this:
image

image

@skjnldsv skjnldsv added this to the Nextcloud 30 milestone Jul 31, 2024
@skjnldsv skjnldsv requested a review from a team July 31, 2024 15:31
@skjnldsv skjnldsv self-assigned this Jul 31, 2024
@skjnldsv skjnldsv requested review from ArtificialOwl, icewind1991 and yemkareems and removed request for a team July 31, 2024 15:31
@skjnldsv skjnldsv requested review from Altahrim and come-nc July 31, 2024 15:32
AndyScherzinger
AndyScherzinger approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@blizzz blizzz mentioned this pull request Aug 1, 2024
Merged
@skjnldsv skjnldsv requested a review from come-nc August 2, 2024 06:59
@skjnldsv skjnldsv enabled auto-merge August 2, 2024 06:59
@Altahrim Altahrim mentioned this pull request Aug 5, 2024
Merged
@skjnldsv
fix(files_sharing): filter out invalid shareWith in sharee API
712965d 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit 119543e into master Aug 6, 2024
169 checks passed
@skjnldsv skjnldsv deleted the fix/empty-email branch August 6, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems was automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @AndyScherzinger @come-nc