-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add small font size variable #46925
Add small font size variable #46925
Conversation
|
This is needed to create a bit more hyerarchy between more important and less important text. For example for the talk conversation description in the header or in NcListItem's "subname" Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
50909f3
to
9855485
Compare
@@ -49,6 +49,7 @@ | |||
--color-border-maxcontrast: #7d7d7d; | |||
--font-face: system-ui, -apple-system, 'Segoe UI', Roboto, Oxygen-Sans, Cantarell, Ubuntu, 'Helvetica Neue', 'Noto Sans', 'Liberation Sans', Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji'; | |||
--default-font-size: 15px; | |||
--font-size-small: 13px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use 12px as that is the currently smallest font size we need to use (and fits the grid baseline)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed too small compared to the default one and looked odd when both are used in the same component (e.g.) Line and subline. I think we should bring all the 12px instances up to 13 for now.
No description provided.