fix: fix passing additional db connection parameters in factory #46931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
Merged
susnux
approved these changes
Aug 1, 2024
|
could this be backported into 29? |
1 task
Merged
|
/backport to stable29 |
|
/backport to stable28 |
icewind1991
requested review from
a team,
ArtificialOwl,
Altahrim and
yemkareems
and removed request for
a team
juliushaertl
approved these changes
Aug 5, 2024
This was referenced Aug 5, 2024
8 tasks
|
Still happening under 29.0.7, unfortunately. |
|
Just updated to 30.0.0, and the same error message is coming up when I try to convert the database to mySQL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I can tell, the added logic for the primary/replica broke passing additional query parameters as the
$additionalConnectionParamsgot merged with the['primary' => ..., 'replica' => ...]array, not the actual connection parameters.