Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): cancel move-copy action should not be handled as an error #46963

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 1, 2024

Summary

Instead we should just show an information message why the file is not moved / copied.

Bildschirmaufnahme_20240801_182851.webm

Checklist

@susnux susnux added this to the Nextcloud 30 milestone Aug 1, 2024
@susnux susnux requested review from SystemKeeper, nfebe and Pytal August 1, 2024 16:32
@susnux susnux requested a review from skjnldsv as a code owner August 1, 2024 16:32
@susnux
Copy link
Contributor Author

susnux commented Aug 1, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Aug 1, 2024

/backport to stable28

@blizzz blizzz mentioned this pull request Aug 1, 2024
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 1, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Aug 1, 2024

/compile amend-rebase /dist

@skjnldsv skjnldsv enabled auto-merge August 1, 2024 20:38
Instead we should just show an information message why the file is not moved / copied.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv merged commit aabd6ef into master Aug 2, 2024
111 checks passed
@skjnldsv skjnldsv deleted the fix/move-copy-error branch August 2, 2024 00:20
@Altahrim Altahrim mentioned this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Canceling a move operation should not show an error
3 participants