fix: Ensure app overflow menu is rendered centered #47031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
ChristophWurst,
juliusknorr,
Pytal and
marcoambrosini
Merged
juliusknorr
approved these changes
Aug 6, 2024
Merged
1. Fix app menu overflow button to be centered 2. Ensure the overflow calculation always just removed one element (incl. refactor to use `@vueuse`) 3. Ensure we use 1.5 line height for app menu, otherwise some languages look squashed under the app icon Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
AndyScherzinger
force-pushed
the
fix/app-menu
branch
from
26d93c9 to
91f7893
Compare
|
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
AndyScherzinger
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@vueuse)Checklist