-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(encryption): Fix mountpoint check to accept if several are found #47044
fix(encryption): Fix mountpoint check to accept if several are found #47044
Conversation
There is no strong requirement to have only one mount for a given storage id. Also the error in this case would be misleading. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
/backport to stable29 |
/backport to stable28 |
This introduced a regression when using groupfolders and encryption. Now it is no longer possible to move a file from a groupfolder to the home storage if the encryption module is enabled, even if neither the groupfolder nor the home storage are encrypted (this is unrelated to nextcloud/groupfolders#2942, which fixes moving files into an encrypted groupfolder). This is reproducible in latest master and stable30, but also on stable29 and stable28 due to the backports; it is already present in Nextcloud 28.0.9rc1 and 29.0.5rc1. How to reproduce
Expected resultThe file is moved Actual resultAn internal error occurs:
|
Summary
There is no strong requirement to have only one mount for a given
storage id. Also the error in this case would be misleading.
Avoids errors "Could not find mount point, can't keep encryption keys" in situations where several mounts are found for the storage.
Checklist