Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(previews): Don't crash on animated WEBP images #47079

Merged
merged 1 commit into from
Aug 7, 2024

Commits on Aug 6, 2024

  1. fix(previews): Don't crash on animated WEBP images

    Fixes #30029 and #37263
    
    libgd handles animated WEBP images poorly and generates a meaningless error message as a result. We were returning a 500 error for these preview requests (web) and a fatal error at the command-line (occ). Now we bypass libgd if the we detect an animated WEBP image (and simply don't generate the preview). No more 500 error. Should fix occ too.
    
    Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
    Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
    joshtrichards authored and backportbot[bot] committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    2c58184 View commit details
    Browse the repository at this point in the history