-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(systemtags): Correctly load tagged files in "tags"-files-view #47120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
/backport to stable29 |
/backport to stable28 |
/compile |
Merged
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
skjnldsv
approved these changes
Aug 8, 2024
We need tests for this 🙈 |
AndyScherzinger
approved these changes
Aug 8, 2024
Merged to have it in Beta5 but created a follow-up at #47127 to have an issue for implementing tests |
This was referenced Aug 8, 2024
I am already writing some, but this was more urgent 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When splitting the path it is
/{ID}
to the splitted array is['', '{ID}']
-> we need to use the last part otherwise we only get 404.