Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(systemtags): Correctly load tagged files in "tags"-files-view #47120

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 7, 2024

When splitting the path it is /{ID} to the splitted array is ['', '{ID}'] -> we need to use the last part otherwise we only get 404.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor Author

susnux commented Aug 7, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Aug 7, 2024

/backport to stable28

@susnux
Copy link
Contributor Author

susnux commented Aug 7, 2024

/compile

@susnux susnux mentioned this pull request Aug 7, 2024
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv
Copy link
Member

skjnldsv commented Aug 8, 2024

We need tests for this 🙈

@AndyScherzinger AndyScherzinger merged commit 2777cf9 into master Aug 8, 2024
111 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/systemtags branch August 8, 2024 08:00
@AndyScherzinger
Copy link
Member

Merged to have it in Beta5 but created a follow-up at #47127 to have an issue for implementing tests

@susnux
Copy link
Contributor Author

susnux commented Aug 8, 2024

We need tests for this 🙈

I am already writing some, but this was more urgent 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants