Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't save translated predefined user status as custom status #47258

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 15, 2024

Summary

Couple of times I saw "predefined" user statuses like "Out sick" and "Vacationing" flying by in what I assumed is the user's language and not mine. Turns out that happens when you select a predefined status and then change the "Clear at".

Can be confirmed by doing the following steps:

  1. Select a predefined status
  2. Optionally: Reload the page
  3. Open status dialog again and change the "Clear at"
  4. Check database state

Before

grafik

After

grafik

Checklist

…ging "Clear at"

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. regression feature: status labels Aug 15, 2024
@nickvergessen nickvergessen added this to the Nextcloud 31 milestone Aug 15, 2024
@nickvergessen nickvergessen self-assigned this Aug 15, 2024
@nickvergessen
Copy link
Member Author

/backport 50c48aa to stable30

@nickvergessen
Copy link
Member Author

/backport 50c48aa to stable29

@nickvergessen
Copy link
Member Author

/backport 50c48aa to stable28

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug feature: status papercut Annoying recurring issue with possibly simple fix. regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants