Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] Apply group limit on remove from group #47325

Merged
merged 7 commits into from
Aug 27, 2024
Merged

[stable27] Apply group limit on remove from group #47325

merged 7 commits into from
Aug 27, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 19, 2024 •
edited by come-nc
Loading

@backportbot backportbot bot requested review from come-nc, skjnldsv and sorbaugh August 19, 2024 13:13
@backportbot backportbot bot added the 3. to review Waiting for reviews label Aug 19, 2024
@come-nc come-nc self-assigned this Aug 19, 2024
@come-nc come-nc force-pushed the backport/47227/stable27 branch from 3d54d9c to e82ccee Compare August 19, 2024 14:03
@come-nc come-nc changed the title [stable27] [stable28] Apply group limit on remove from group [stable27] Apply group limit on remove from group Aug 19, 2024
@come-nc come-nc marked this pull request as ready for review August 19, 2024 14:06
@come-nc
Copy link
Contributor

come-nc commented Aug 20, 2024

So, bad news here, stable27 is not compatible with the cypress tests in there.
So the tests should be removed and this should be tested by hand to make sure it’s fixed in this PR on 27.

@come-nc come-nc force-pushed the backport/47227/stable27 branch from e82ccee to bc4802f Compare August 22, 2024 13:08
@come-nc
Copy link
Contributor

come-nc commented Aug 22, 2024

So, bad news here, stable27 is not compatible with the cypress tests in there. So the tests should be removed and this should be tested by hand to make sure it’s fixed in this PR on 27.

Tested, it works, and removed incompatible test from PR.
Good to merge.

@come-nc
Copy link
Contributor

come-nc commented Aug 22, 2024

/backport to stable26

@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 27, 2024
artonge and others added 7 commits August 27, 2024 11:02
@artonge @come-nc
fix(files_sharing): Delete user shares if needed when user is removed…
3abb793 
… from a group

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge @come-nc
chore(tests): Test limiting sharing to same group
b7efb79 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@come-nc
fix: Remove shares only if there are no more common groups between users
46c68ef 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix(tests): Adapt tests to change of DefaultShareProvider constructor
2655f93 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix(tests): Fix PHP 8.0 compatibility
3904bf5 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix: Remove call to non-existing method in 28 and add missing use in …
bcb1bbb 
…test

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
chore: Remove test not compatible with 27 and below
850a0b3 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the backport/47227/stable27 branch from bc4802f to 850a0b3 Compare August 27, 2024 09:02
@AndyScherzinger AndyScherzinger merged commit 0e08a64 into stable27 Aug 27, 2024
36 of 40 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/47227/stable27 branch August 27, 2024 11:16
@backportbot backportbot bot mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees

@come-nc come-nc

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@come-nc @skjnldsv @AndyScherzinger @artonge