fix: Display 'Leave share' instead of 'Delete' #47339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
requested review from
skjnldsv,
a team,
artonge and
nfebe
and removed request for
a team
marcelklehr
force-pushed
the
fix/leave-share-instead-of-delete
branch
from
99e6f23 to
70a642c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
skjnldsv
approved these changes
Aug 20, 2024
skjnldsv
requested changes
Aug 20, 2024
skjnldsv
force-pushed
the
fix/leave-share-instead-of-delete
branch
from
70a642c to
10259c3
Compare
skjnldsv
requested review from
provokateurin,
nickvergessen,
Pytal,
icewind1991,
come-nc,
ArtificialOwl,
szaimen,
susnux,
datenangebot,
danxuliu,
ChristophWurst,
miaulalala,
tcitworld,
julien-nc,
juliusknorr and
kesselb
as code owners
skjnldsv
force-pushed
the
fix/leave-share-instead-of-delete
branch
2 times, most recently
from
9e58191 to
22613f5
Compare
|
Oof, this turned out to be a deeper rabbit hole than I anticipated. Thank you for digging into this @skjnldsv 💙 |
Yeah 🥲🫠🫠🫠 |
|
Still a few tests to adjust 😅 |
skjnldsv
force-pushed
the
fix/leave-share-instead-of-delete
branch
7 times, most recently
from
40cd3e4 to
2a1ac7e
Compare
…eck methods Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/leave-share-instead-of-delete
branch
from
2a1ac7e to
bb37954
Compare
|
Finally! 😓 |
2 tasks
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
/backport to stable29 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In files in the "Shared With Me" view, shares' context menu display a "Delete" entry when it should say "Leave this share". This PR fixes that.
Checklist