fix(files_sharing): Sort by correct share attribute ("share with displayname") #47365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable30 |
Pytal
approved these changes
Aug 20, 2024
AndyScherzinger
approved these changes
Aug 20, 2024
…layname") There is no `title` attribute, so this causes an exception. Instead sort by the "share with" displayname which will be the user or group the node is shared to. Meaning this will also be the title of the share in the UI. If this is not available or there are multiple for the same, then sort by the custom label. If also this is not set sort by the creation time. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/share-sorting
branch
from
d6a853c to
dc153f2
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is no
titleattribute, so this causes an exception. Instead sort by the "share with" displayname which will be the user or group the node is shared to. Meaning this will also be the title of the share in the UI. If this is not available or there are multiple for the same, then sort by the custom label. If also this is not set sort by the creation time.Checklist