Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] fix(files): Move loading icon before grid toggle #47392

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 21, 2024

Backport of #47370

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from artonge, skjnldsv and susnux August 21, 2024 12:39
@backportbot backportbot bot added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: files labels Aug 21, 2024
@backportbot backportbot bot added this to the Nextcloud 30.0.1 milestone Aug 21, 2024
@susnux susnux force-pushed the backport/47370/stable30 branch from 6638ac0 to b583f12 Compare August 21, 2024 14:55
@susnux
Copy link
Contributor

susnux commented Aug 21, 2024

/compile

@susnux susnux marked this pull request as ready for review August 21, 2024 14:55
@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 21, 2024
@susnux susnux modified the milestones: Nextcloud 30.0.1, Nextcloud 30 Aug 21, 2024
susnux and others added 2 commits August 21, 2024 17:38
This prevents jumping of that toggle button when the view is loading.
Also adjust the design for Nextcloud 30 (prevent jumping of breadcrumbs when loading due to increased height).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger AndyScherzinger force-pushed the backport/47370/stable30 branch from 8160f58 to 0f2ea40 Compare August 21, 2024 15:38
@AndyScherzinger AndyScherzinger merged commit a1e1e2d into stable30 Aug 21, 2024
110 of 111 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/47370/stable30 branch August 21, 2024 18:57
@skjnldsv skjnldsv mentioned this pull request Aug 22, 2024
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants