Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] fix(files_versions): Migrate version name dialog from NcModal to NcDialog #47436

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 22, 2024

Backport of #47407

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: versions labels Aug 22, 2024
@backportbot backportbot bot added this to the Nextcloud 30.0.1 milestone Aug 22, 2024
@susnux
Copy link
Contributor

susnux commented Aug 28, 2024

/compile amend/

@susnux susnux marked this pull request as ready for review August 28, 2024 18:32
…alog

* Resolves nextcloud/viewer#2390

Make the version name dialog a real dialog instead of a modal.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger AndyScherzinger merged commit ce0b75c into stable30 Aug 28, 2024
113 of 114 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/47407/stable30 branch August 28, 2024 22:16
@blizzz blizzz mentioned this pull request Aug 29, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants