test: Migrate from Jest to vitest #47466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Aug 25, 2024
artonge
approved these changes
Aug 26, 2024
susnux
force-pushed
the
chore/migrate-vitest
branch
from
0dce19a to
44afaf4
Compare
There are some benefits, like faster tests and thus saving CI time, but the main reason for me is: Jest still does not properly support ESM packages, this casues a lot of breaking stuff. Sometimes you need to adjust imports for mocking, and somethimes other random stuff break. Instead of wasting valuable developer lifetime we can use vitest which works perfectly with ESM. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/migrate-vitest
branch
from
44afaf4 to
30d090f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are some benefits, like faster tests and thus saving CI time, but the main reason for me is¹:
Jest still does not properly support ESM packages, this causes a lot of stuff breaking.
Sometimes you need to adjust imports for mocking, and sometimes other random stuff break.
Instead of wasting valuable developer lifetime we can use vitest which works perfectly with ESM.
Running locally:
¹ (really just annoyed by wasting time fixing tests that are not broken but the testing framework is...)
Checklist