Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Delegate is-encrypted handling to the e2ee app #47495

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Aug 26, 2024

The is-encrypted property is signaling the E2EE status, not the SSE one. So it does not make sense to keep it in the server repo.

@artonge artonge self-assigned this Aug 26, 2024
@artonge artonge added 3. to review Waiting for reviews feature: encryption (server-side) feature: dav php Pull requests that update Php code labels Aug 26, 2024
@artonge artonge added this to the Nextcloud 30.0.1 milestone Aug 26, 2024
@artonge artonge force-pushed the artonge/dept/delegat_is_encrypted_to_e2ee branch 2 times, most recently from ae9c61e to 6426b78 Compare August 26, 2024 17:30
@artonge
Copy link
Contributor Author

artonge commented Aug 26, 2024

/backport to stable30

@artonge artonge force-pushed the artonge/dept/delegat_is_encrypted_to_e2ee branch 2 times, most recently from 876c7c6 to 4097250 Compare August 26, 2024 17:39
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/dept/delegat_is_encrypted_to_e2ee branch from 4097250 to ac1d8cd Compare August 26, 2024 17:45
@artonge artonge changed the title debt: Delegate is-encrypted handling to the e2ee app feat: Delegate is-encrypted handling to the e2ee app Aug 26, 2024
@come-nc
Copy link
Contributor

come-nc commented Aug 27, 2024

Wait, but FileInfo::isEncrypted is used for SSE and not E2EE, no?

@artonge
Copy link
Contributor Author

artonge commented Aug 27, 2024

Wait, but FileInfo::isEncrypted is used for SSE and not E2EE, no?

Not sure that I get the concern, but in this case, isEncrypted() was called inside a $node instanceof Directory condition, so this was only targeting E2EE folders and not SSE files.

@artonge artonge merged commit d2c3726 into master Aug 27, 2024
171 checks passed
@artonge artonge deleted the artonge/dept/delegat_is_encrypted_to_e2ee branch August 27, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants