-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Delegate is-encrypted handling to the e2ee app #47495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
3. to review
Waiting for reviews
feature: encryption (server-side)
feature: dav
php
Pull requests that update Php code
labels
Aug 26, 2024
artonge
force-pushed
the
artonge/dept/delegat_is_encrypted_to_e2ee
branch
2 times, most recently
from
August 26, 2024 17:30
ae9c61e
to
6426b78
Compare
/backport to stable30 |
artonge
force-pushed
the
artonge/dept/delegat_is_encrypted_to_e2ee
branch
2 times, most recently
from
August 26, 2024 17:39
876c7c6
to
4097250
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/dept/delegat_is_encrypted_to_e2ee
branch
from
August 26, 2024 17:45
4097250
to
ac1d8cd
Compare
artonge
changed the title
debt: Delegate is-encrypted handling to the e2ee app
feat: Delegate is-encrypted handling to the e2ee app
Aug 26, 2024
come-nc
approved these changes
Aug 27, 2024
Wait, but FileInfo::isEncrypted is used for SSE and not E2EE, no? |
Not sure that I get the concern, but in this case, |
sorbaugh
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
feature: dav
feature: encryption (server-side)
php
Pull requests that update Php code
technical debt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is-encrypted property is signaling the E2EE status, not the SSE one. So it does not make sense to keep it in the server repo.