Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Port Same-Site Cookies to master #476

Merged
merged 1 commit into from
Jul 20, 2016
Merged

[master] Port Same-Site Cookies to master #476

merged 1 commit into from
Jul 20, 2016

Conversation

LukasReschke
Copy link
Member

Fixes #50

@LukasReschke LukasReschke added the 3. to review Waiting for reviews label Jul 20, 2016
@LukasReschke LukasReschke added this to the Nextcloud Next milestone Jul 20, 2016
@mention-bot
Copy link

@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @BernhardPosselt and @rullzer to be potential reviewers

@MorrisJobke
Copy link
Member

💥

PHP Fatal error:  Class 'OC\Appframework\Middleware\Security\Exceptions\StrictCookieMissingException' not found in /drone/src/github.com/nextcloud/server/lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php on line 141
[info] build failed (exit code 255)

@LukasReschke
Copy link
Member Author

PHP Fatal error: Class 'OC\Appframework\Middleware\Security\Exceptions\StrictCookieMissingException' not found in /drone/src/github.com/nextcloud/server/lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php on line 141
[info] build failed (exit code 255)

How much I love case-sensitive and case-insensitive OS…

@LukasReschke
Copy link
Member Author

Casing changed. Let's see if Drone is happy now… Tests are passing locally… (well they also passed before but 🙈 yay … computers 😉 )

@rullzer
Copy link
Member

rullzer commented Jul 20, 2016

👍

@LukasReschke
Copy link
Member Author

Since it's a simple port to master: Merge.

@LukasReschke LukasReschke merged commit 020a2a6 into master Jul 20, 2016
@LukasReschke LukasReschke deleted the port-same-site-cookies branch July 20, 2016 19:35
@dwoodiwiss dwoodiwiss mentioned this pull request Apr 19, 2022
Open
@gisforgirard gisforgirard mentioned this pull request Apr 19, 2022
Open
@checkoss checkoss mentioned this pull request Apr 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2022
Open
@Jessi1983 Jessi1983 mentioned this pull request Apr 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Apr 20, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Jul 7, 2022
Open
This was referenced Jul 7, 2022
Open
Open
@dwoodiwiss dwoodiwiss mentioned this pull request Jul 7, 2022
Open
@violethaze74 violethaze74 mentioned this pull request Jul 8, 2022
Open
@TomG736 TomG736 mentioned this pull request Jul 8, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jul 8, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 7, 2022
Open
@TomG736 TomG736 mentioned this pull request Oct 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@LukasReschke @mention-bot @MorrisJobke @rullzer