-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use the blurhash in Files #47605
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
artonge
commented
Aug 29, 2024
•
edited
Loading
edited
List view | Grid view |
---|---|
artonge
added
enhancement
3. to review
Waiting for reviews
feature: files
javascript
labels
Aug 29, 2024
artonge
force-pushed
the
artonge/feat/files_blurhash
branch
from
August 29, 2024 12:31
c025414
to
7019db8
Compare
/compile amend / |
susnux
reviewed
Aug 29, 2024
susnux
reviewed
Aug 29, 2024
susnux
reviewed
Aug 29, 2024
susnux
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks super nice! Just a few a11y and TS comments :)
artonge
force-pushed
the
artonge/feat/files_blurhash
branch
from
August 29, 2024 12:46
7019db8
to
36dfaae
Compare
nextcloud-command
force-pushed
the
artonge/feat/files_blurhash
branch
from
August 29, 2024 12:47
36dfaae
to
df60ea0
Compare
artonge
force-pushed
the
artonge/feat/files_blurhash
branch
from
August 29, 2024 14:04
df60ea0
to
be57ebb
Compare
susnux
reviewed
Aug 29, 2024
susnux
reviewed
Aug 29, 2024
susnux
reviewed
Aug 29, 2024
artonge
force-pushed
the
artonge/feat/files_blurhash
branch
from
August 29, 2024 15:23
be57ebb
to
b7bdfce
Compare
susnux
approved these changes
Aug 29, 2024
skjnldsv
approved these changes
Aug 29, 2024
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
artonge/feat/files_blurhash
branch
from
August 29, 2024 21:08
e388b7f
to
75a684a
Compare
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.