fix(css): Adjust header styles to only add focus-visible styles to menu #47616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
skjnldsv
approved these changes
Aug 30, 2024
Only the main menu should be styles by the header styles, not the popover menus. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/header-styles
branch
from
3432a75 to
cc8368b
Compare
|
/backport to stable30 |
|
Failure unrelated |
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Only the main menu should be styles by the header styles, not the popover menus.
See e.g. the popover menu of the avatar ("account menu") in the following screen recording.
Screen recording
Before
Bildschirmaufnahme_20240829_234303.webm
After
Bildschirmaufnahme_20240829_234112.webm
Checklist