Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(settings): Hide forbidden UI elements for group managers #47687

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 2, 2024

Summary

  1. The "recent" accounts API only works for admin and delegated admin -> hide for group managers
  2. Group managers can not create new groups -> Hide the UI to add a new group for them
  3. Accounts created by group managers require one of the groups, which is managed by the group manager, assigned. So if the group manager only manageres a single group, we should preselect that group.

Checklist

@susnux susnux added bug 3. to review Waiting for reviews labels Sep 2, 2024
@susnux susnux added this to the Nextcloud 29.0.6 milestone Sep 2, 2024
@susnux susnux requested review from artonge, a team, Pytal and szaimen and removed request for a team September 2, 2024 15:59
1. The "recent" accounts API only works for admin and delegated admin -> hide for group managers
2. Group managers can not create new groups -> Hide the UI to add a new group for them
3. Accounts created by group managers require one of the groups, which is managed by the group manager, assigned.
   So if the group manager only manageres a single group, we should preselect that group.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@AndyScherzinger AndyScherzinger force-pushed the backport/29/ui-group-mgr branch from 5190aad to 577a504 Compare September 2, 2024 18:23
@AndyScherzinger
Copy link
Member

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 2, 2024
@AndyScherzinger AndyScherzinger merged commit 1f394cb into stable29 Sep 2, 2024
109 of 110 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/29/ui-group-mgr branch September 2, 2024 20:41
@blizzz blizzz mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants