[stable29] [oauth2] Store hashed secret instead of encrypted #47700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
added
enhancement
3. to review
|
/compile |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -156,7 +156,8 @@ | |||
| } | |||
|
|
|||
| try { | |||
| $storedClientSecret = $this->crypto->decrypt($client->getSecret()); | |||
| $storedClientSecretHash = $client->getSecret(); | |||
| $clientSecretHash = bin2hex($this->crypto->calculateHMAC($client_secret)); | |||
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
Merged
julien-nc
force-pushed
the
backport/47635/stable29
branch
from
2509793 to
48cf4a9
Compare
|
/compile |
AndyScherzinger
force-pushed
the
backport/47635/stable29
branch
from
a36c434 to
a091a78
Compare
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
backport/47635/stable29
branch
from
a091a78 to
a60b8c5
Compare
|
/compile |
AndyScherzinger
approved these changes
Sep 4, 2024
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #47635