Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix missing footer on public pages #47761

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Sep 4, 2024

Resolves

Before After
image image

Checklist

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added bug 3. to review Waiting for reviews regression labels Sep 4, 2024
@Pytal Pytal added this to the Nextcloud 31 milestone Sep 4, 2024
@Pytal Pytal self-assigned this Sep 4, 2024
@Pytal Pytal enabled auto-merge September 4, 2024 23:46
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes 🙈

@sorbaugh

This comment was marked as resolved.

@sorbaugh
Copy link
Contributor

sorbaugh commented Sep 5, 2024

@Pytal @susnux do we know if the failing tests are related?

@Pytal
Copy link
Member Author

Pytal commented Sep 5, 2024

/backport to stable30

Is only applicable to 31 actually 🙈

@Pytal @susnux do we know if the failing tests are related?

Failing OCI+sharding is known to fail already and mysql is flaky here so not related

@sorbaugh sorbaugh disabled auto-merge September 5, 2024 16:02
@sorbaugh sorbaugh merged commit c2f87fb into master Sep 5, 2024
164 of 174 checks passed
@sorbaugh sorbaugh deleted the fix/missing-footer branch September 5, 2024 16:02
Copy link

backportbot bot commented Sep 5, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/47761/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 4fed8ed8

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47761/stable30

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants