Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix: add option to remove the webroot for setup checks and don't chec… #47774

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 5, 2024

Backport of PR #46255

kesselb and others added 2 commits September 5, 2024 15:53
…k trusted_domains.

1) The checks for well-known urls should always run against the root domain and therefore the option to remove the webroot.

2) For trusted domains, the available protocol is unknown, and thus some guesswork would be needed to make that work. I've decided for now to not consider them anymore to reduce false-positives.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 trusted domains as last fallback.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@backportbot backportbot bot requested review from come-nc, susnux and kesselb September 5, 2024 15:53
@backportbot backportbot bot added bug 3. to review Waiting for reviews labels Sep 5, 2024
@backportbot backportbot bot added this to the Nextcloud 29.0.7 milestone Sep 5, 2024
@AndyScherzinger AndyScherzinger merged commit 98a0a8c into stable29 Sep 5, 2024
175 of 177 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/46255/stable29 branch September 5, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants