chore: adjust code to adhere to coding standard #47789
Conversation
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
added
3. to review
Signed-off-by: Anna Larch <anna@nextcloud.com>
| @@ -397,8 +397,7 @@ private function doSoftValidation(): void { | |||
| } | |||
|
|
|||
| foreach (['ldapExpertUUIDUserAttr' => 'ldapUuidUserAttribute', | |||
| 'ldapExpertUUIDGroupAttr' => 'ldapUuidGroupAttribute'] | |||
| as $expertSetting => $effectiveSetting) { | |||
| 'ldapExpertUUIDGroupAttr' => 'ldapUuidGroupAttribute'] as $expertSetting => $effectiveSetting) { | |||
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $calendar = $this->caldavBackend->getCalendarByUri($this->principalInfo['uri'], $name); | ||
| if(!empty($calendar)) { | ||
| if (!empty($calendar)) { |
Check notice
Code scanning / Psalm
RiskyTruthyFalsyComparison Note
| return ['old' => null, 'new' => $newEventComponents]; | ||
| } | ||
|
|
||
| $oldEventComponents = $old->getComponents(); | ||
| if(is_array($oldEventComponents) && !empty($oldEventComponents)) { | ||
| if (is_array($oldEventComponents) && !empty($oldEventComponents)) { |
Check notice
Code scanning / Psalm
RedundantConditionGivenDocblockType Note
| @@ -151,7 +151,7 @@ | |||
|
|
|||
| // No changed events after all - this shouldn't happen if there is significant change yet here we are | |||
| // The scheduling status is debatable | |||
| if(empty($vEvent)) { | |||
| if (empty($vEvent)) { | |||
Check notice
Code scanning / Psalm
DocblockTypeContradiction Note
| @@ -151,7 +151,7 @@ | |||
|
|
|||
| // No changed events after all - this shouldn't happen if there is significant change yet here we are | |||
| // The scheduling status is debatable | |||
| if(empty($vEvent)) { | |||
| if (empty($vEvent)) { | |||
Check notice
Code scanning / Psalm
DocblockTypeContradiction Note
| /** @var Parameter $partstat */ | ||
| $partstat = $organizer['PARTSTAT']; | ||
| if(strcasecmp($partstat->getValue(), 'ACCEPTED') === 0) { | ||
| if (strcasecmp($partstat->getValue(), 'ACCEPTED') === 0) { |
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
| @@ -101,7 +101,7 @@ | |||
| if (isset($component['DTSTART']) && $userStatusTimestamp !== null) { | |||
| /** @var DateTimeImmutable $dateTime */ | |||
| $dateTime = $component['DTSTART'][0]; | |||
| if($dateTime instanceof DateTimeImmutable && $userStatusTimestamp > $dateTime->getTimestamp()) { | |||
| if ($dateTime instanceof DateTimeImmutable && $userStatusTimestamp > $dateTime->getTimestamp()) { | |||
Check notice
Code scanning / Psalm
RedundantConditionGivenDocblockType Note
| @@ -58,7 +58,7 @@ | |||
| } | |||
|
|
|||
| // Don't add share for owner | |||
| if($shareable->getOwner() !== null && strcasecmp($shareable->getOwner(), $principal) === 0) { | |||
| if ($shareable->getOwner() !== null && strcasecmp($shareable->getOwner(), $principal) === 0) { | |||
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
| @@ -83,7 +83,7 @@ | |||
| } | |||
|
|
|||
| // Don't add unshare for owner | |||
| if($shareable->getOwner() !== null && strcasecmp($shareable->getOwner(), $principal) === 0) { | |||
| if ($shareable->getOwner() !== null && strcasecmp($shareable->getOwner(), $principal) === 0) { | |||
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
| @@ -499,10 +499,10 @@ | |||
| return; | |||
| } | |||
| // If there is a custom message, don't overwrite it | |||
| if(empty($status->getCustomMessage())) { | |||
| if (empty($status->getCustomMessage())) { | |||
Check notice
Code scanning / Psalm
RiskyTruthyFalsyComparison Note
| $status->setCustomMessage($predefinedMessage['message']); | ||
| } | ||
| if(empty($status->getCustomIcon())) { | ||
| if (empty($status->getCustomIcon())) { |
Check notice
Code scanning / Psalm
RiskyTruthyFalsyComparison Note
miaulalala
requested review from
nickvergessen,
ChristophWurst and
tcitworld
as code owners
Summary
New coding standard fixes
Checklist