Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(appstore): return if appstore is manually disabled #47871

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 10, 2024

Backport of PR #47834

solracsf and others added 2 commits September 10, 2024 14:33
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: camel case

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: log a debug log

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: typing

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: typo

fix: typing
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@backportbot backportbot bot added the 3. to review Waiting for reviews label Sep 10, 2024
@backportbot backportbot bot added this to the Nextcloud 29.0.7 milestone Sep 10, 2024
@@ -172,10 +172,17 @@
$this->ignoreMaxVersion = $ignoreMaxVersion;
}


public function get($allowUnstable = false) {
public function get($allowUnstable = false): array {

Check notice

Code scanning / Psalm

MissingParamType Note

Parameter $allowUnstable has no provided type
@Altahrim Altahrim mentioned this pull request Sep 11, 2024
14 tasks
@skjnldsv skjnldsv merged commit 6a46dad into stable29 Sep 15, 2024
174 of 177 checks passed
@skjnldsv skjnldsv deleted the backport/47834/stable29 branch September 15, 2024 20:54
@Altahrim Altahrim mentioned this pull request Oct 1, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants