Migrate away from OC_App to IAppManager #47927
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
come-nc
force-pushed
the
fix/migrate-away-from-oc_app
branch
2 times, most recently
from
07141d5 to
2abf2d8
Compare
…_App Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/migrate-away-from-oc_app
branch
from
2abf2d8 to
7a16d01
Compare
come-nc
requested review from
ChristophWurst,
miaulalala,
nickvergessen and
st3iny
as code owners
come-nc
requested review from
susnux and
provokateurin
and removed request for
nickvergessen,
ChristophWurst,
st3iny and
miaulalala
come-nc
added
3. to review
come-nc
requested review from
a team,
ArtificialOwl and
Altahrim
and removed request for
a team
| $apps = array_unique($apps); | ||
|
|
||
| return $apps; | ||
| return \OCP\Server::get(IAppManager::class)->getAllAppsInAppsFolders(); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
Can we also deprecate this in favor of \OCP\Support\Subscription\IRegistry::delegateGetSupportedApps ?
There was a problem hiding this comment.
I would do the opposite 🙈
There was a problem hiding this comment.
Why the opposite?
@susnux yeah we should. But I won’t do it in this PR to keep it mergeable. This kind of cleanup needs to be merged quickly or it conflicts fast.
There was a problem hiding this comment.
Why the opposite?
From my perspective the subscription methods are "internal" and are used by (other) public components.
All the delegate*() functions are only called from "lib/private/ implementing public interfaces", settings app, support app or update checks.
There was a problem hiding this comment.
Maybe getSupportedApps can be moved to the AppManager then.
In the mean time, would one of you two approve this here PR? :-P
Follow-up of #44025
Summary
Migrate most calls of
OC_App::getAppPath,OC_App::cleanAppId,OC_App::getAllAppsto calls on the AppManager instance. The later two were added to the OCP interface for the occasion.Checklist