Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump version to run sha256 for background job arguments migration #47930

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Sep 12, 2024

  • Resolves: error when enabling an app

Summary

Follow-up for #47769

TODO

  • CI

Checklist

Follow-up for #47769

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb added the 3. to review Waiting for reviews label Sep 12, 2024
@kesselb kesselb added this to the Nextcloud 31 milestone Sep 12, 2024
@kesselb kesselb requested review from AndyScherzinger, artonge and a team September 12, 2024 15:59
@kesselb kesselb self-assigned this Sep 12, 2024
@kesselb kesselb requested review from Altahrim and sorbaugh and removed request for a team September 12, 2024 15:59
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
Copy link
Contributor Author

kesselb commented Sep 12, 2024

I pushed another commit to bump the 3rdparty version and fix the check "Block merging with outdated 3rdparty".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated no?

Copy link
Contributor Author

@kesselb kesselb Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unrelated, but without the required check for 3rdparty is failing.
If you prefer, I drop the commit and send another pr.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged, done is better than perfect (PRs)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No makes sense, so 👍

@AndyScherzinger
Copy link
Member

@artonge is this a must merge for v30.0.0?

@susnux
Copy link
Contributor

susnux commented Sep 12, 2024

is this a must merge for v30.0.0?

The version is bumped during the RC creation by the release team, so this should be good for all stable branches.
But for current master we did not bump the version so it is only requited for 31.

@AndyScherzinger AndyScherzinger merged commit d0275a7 into master Sep 12, 2024
178 checks passed
@AndyScherzinger AndyScherzinger deleted the chore/noid/bump-db-version branch September 12, 2024 19:37
@kesselb kesselb changed the title build: bump version to run sha265 for background job arguments migration build: bump version to run sha256 for background job arguments migration Sep 17, 2024
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants