-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump version to run sha256 for background job arguments migration #47930
Conversation
Follow-up for #47769 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
I pushed another commit to bump the 3rdparty version and fix the check "Block merging with outdated 3rdparty". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unrelated no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unrelated, but without the required check for 3rdparty is failing.
If you prefer, I drop the commit and send another pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged, done is better than perfect (PRs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No makes sense, so 👍
@artonge is this a must merge for v30.0.0? |
The version is bumped during the RC creation by the release team, so this should be good for all stable branches. |
Summary
Follow-up for #47769
TODO
Checklist