fix(Entity): Fix magic setter call for custom strong typed setters #48008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
miaulalala,
come-nc,
a team,
icewind1991 and
sorbaugh
and removed request for
a team
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
fix/entity/strict-types
branch
from
1d5193a to
247b1dd
Compare
provokateurin
changed the title
|
Enforcing strict types triggers some Oracle null related problems, so I'm not going to bother with that right now (also makes backporting easier). |
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
miaulalala
approved these changes
Sep 15, 2024
skjnldsv
approved these changes
Sep 16, 2024
|
/backport to stable28 |
|
/backport to stable29 |
|
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference: #47984
Summary
When enforcing strict types in Entity.php the fromRow method can fail if the the type to used to store the data in the db is different from the target php type (e.g. bool in sqlite is integer 0/1).
Usually magic methods are used and those don't have strict types, but if you have a custom setter it will trigger an error because the argument type does not match.
Checklist