Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(FileList): Show correct avatar for federated share owner #48227

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 19, 2024

Backport of #47441

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from come-nc, skjnldsv and nfebe September 19, 2024 20:48
@backportbot backportbot bot added this to the Nextcloud 29.0.8 milestone Sep 19, 2024
@nfebe nfebe changed the title [stable29] [stable28] fix(FileList): Show correct avatar for federated share owner [stable29] fix(FileList): Show correct avatar for federated share owner Sep 19, 2024
@nfebe nfebe marked this pull request as ready for review September 19, 2024 20:53
@nfebe nfebe enabled auto-merge September 19, 2024 20:54
@nfebe
Copy link
Contributor

nfebe commented Sep 19, 2024

/backport to stable30

@come-nc
Copy link
Contributor

come-nc commented Sep 20, 2024

@fenn-cs You need to redo the cherry-pick to make sure no changes are missing and remove the [skip ci] comment. See PR description.

@nfebe
Copy link
Contributor

nfebe commented Sep 20, 2024

Hey @come-nc sure.... I was trying to test it om 29, when my something broke on stable29 docker...

Would resolve this soon.

@nfebe nfebe force-pushed the backport/47441/stable29 branch from f4a8371 to 5abfef6 Compare September 20, 2024 11:56
nfebe and others added 2 commits September 23, 2024 10:50
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe nfebe force-pushed the backport/47441/stable29 branch from 5abfef6 to e56b492 Compare September 23, 2024 09:50
@nfebe
Copy link
Contributor

nfebe commented Sep 23, 2024

/compile amend

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe nfebe merged commit e939fd7 into stable29 Sep 23, 2024
177 checks passed
@nfebe nfebe deleted the backport/47441/stable29 branch September 23, 2024 11:58
@Altahrim Altahrim mentioned this pull request Oct 1, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews 28-feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants