Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable29] refactor(AccountIcon): Remove needless console.log #48315

Merged
merged 2 commits into from
Sep 24, 2024
Merged

[stable29] refactor(AccountIcon): Remove needless console.log #48315

merged 2 commits into from
Sep 24, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Sep 24, 2024

Debug stuff swept in being removed.

@nfebe
refactor(AccountIcon): Remove needless console.log
5b98da6 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe added the 3. to review Waiting for reviews label Sep 24, 2024
@nfebe nfebe enabled auto-merge September 24, 2024 11:43
@nfebe
Copy link
Contributor Author

nfebe commented Sep 24, 2024

/compile

@nfebe
Copy link
Contributor Author

nfebe commented Sep 24, 2024

/backport to stable28

@nfebe nfebe changed the title refactor(AccountIcon): Remove needless console.log [stable29] refactor(AccountIcon): Remove needless console.log Sep 24, 2024
@nextcloud-command
chore(assets): Recompile assets
8907f81 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe nfebe merged commit 13c2c37 into stable29 Sep 24, 2024
106 of 110 checks passed
@nfebe nfebe deleted the fix/remove-needless-console-log branch September 24, 2024 12:44
@backportbot backportbot bot mentioned this pull request Sep 24, 2024
Merged
2 tasks
@Altahrim Altahrim mentioned this pull request Oct 1, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@susnux susnux susnux approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees
No one assigned
Labels
3. to review Waiting for reviews feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nfebe @susnux @artonge @nextcloud-command