Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files_sharing): Parse OCM share permissions from OCM and not OCS prop #48366

Merged
merged 3 commits into from
Sep 26, 2024
Merged

fix(files_sharing): Parse OCM share permissions from OCM and not OCS prop #48366

merged 3 commits into from
Sep 26, 2024

Conversation

provokateurin
Copy link
Member

Summary

Checks for OCM permissions prop, but parses them from the OCS permissions prop.

Checklist

@provokateurin
fix(files_sharing): Parse OCM share permissions from OCM and not OCS …
adc38a7 
…prop

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Sep 26, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Sep 26, 2024
@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin
Copy link
Member Author

/backport to stable29

@provokateurin
Copy link
Member Author

/backport to stable28

come-nc
come-nc reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for the logic, but error handling is missing, $reponse could be false, or could be missing the keys.

@provokateurin
refactor(files_sharing): Make permissions prop checks less error prone
5d4a358 
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
fix(files_sharing): Check if propfind response is valid before access…
13d1cb7 
…ing share permission props

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the fix/files_sharing/ocm-permissions branch from 9266e84 to 13d1cb7 Compare September 26, 2024 12:35
@kesselb kesselb merged commit 0451be7 into master Sep 26, 2024
173 checks passed
@kesselb kesselb deleted the fix/files_sharing/ocm-permissions branch September 26, 2024 14:20
This was referenced Sep 26, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@kesselb kesselb kesselb approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
3 participants
@provokateurin @kesselb @come-nc