Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add PasswordConfirmationRequired to create user storages endpoint #48373

Merged
merged 4 commits into from
Oct 17, 2024
Merged

fix: add PasswordConfirmationRequired to create user storages endpoint #48373

merged 4 commits into from
Oct 17, 2024

Conversation

yemkareems
Copy link
Contributor

@yemkareems yemkareems commented Sep 26, 2024 •
edited by susnux
Loading

  • Resolves: #

Summary

TODO

  • ...

Checklist

@yemkareems yemkareems force-pushed the fix/788/add-password-confirmation-required-to-user-storage-create branch from 604df16 to 3356b46 Compare September 26, 2024 09:54
@susnux susnux force-pushed the fix/788/add-password-confirmation-required-to-user-storage-create branch from 49c4ef7 to fd032dd Compare October 14, 2024 13:12
@yemkareems yemkareems marked this pull request as ready for review October 14, 2024 13:25
@yemkareems yemkareems self-assigned this Oct 14, 2024
@yemkareems yemkareems added the 3. to review Waiting for reviews label Oct 14, 2024
@nickvergessen nickvergessen removed their request for review October 14, 2024 13:40
susnux
susnux approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a sign-off for your commits @yemkareems ;)

yemkareems and others added 3 commits October 16, 2024 16:49
@yemkareems @susnux
fix: add PasswordConfirmationRequired to create user storages endpoint
d3f1b76 
Signed-off-by: yemkareems <yemkareems@gmail.com>
@yemkareems @susnux
fix: add PasswordConfirmationRequired to update and delete method
b86dc07 
Signed-off-by: yemkareems <yemkareems@gmail.com>
@susnux
fix: Add frontend code for password confirmation
3e387d4 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/788/add-password-confirmation-required-to-user-storage-create branch from 8051f3c to 3e387d4 Compare October 16, 2024 14:49
@susnux susnux added this to the Nextcloud 31 milestone Oct 16, 2024
@susnux
Copy link
Contributor

susnux commented Oct 16, 2024

/backport to stable29

@susnux
Copy link
Contributor

susnux commented Oct 16, 2024

/backport to stable28

@susnux
Copy link
Contributor

susnux commented Oct 16, 2024

/backport to stable30

@susnux susnux added the bug label Oct 16, 2024
@susnux susnux requested a review from Pytal October 16, 2024 15:04
@yemkareems yemkareems merged commit de9f5c4 into master Oct 17, 2024
179 checks passed
@yemkareems yemkareems deleted the fix/788/add-password-confirmation-required-to-user-storage-create branch October 17, 2024 05:40
This was referenced Oct 17, 2024
Merged
Merged
Merged
@artonge artonge mentioned this pull request Oct 24, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

@susnux susnux susnux approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@yemkareems yemkareems

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
3 participants
@yemkareems @susnux @provokateurin